Holy overengineering, Batman. IP addresses of all things are trivially parseable into fixed-length byte sequences. Just do that and use a search tree. Or, IDK; this is an extremely solved problem, there are probably even better solutions out there – but I promise you text regex is involved in none of the good ones.
Even for actual string matching, any decent regex engine will compile and optimise an alternation a|b|c|... better than this text wrangling will. Unless you have actual benchmarks showing this gives you an advantage with the engine you’re using, you’re just introducing complexity for no gain.
Why? 🤔
In my case, to efficiently match against a large number of IP addresses and IP address ranges:
https://codeberg.org/tslocum/sriracha/src/commit/5bf24b0daabd058c2714427da17c7ea16b7cd43a/internal/server/server.go#L447
Holy overengineering, Batman. IP addresses of all things are trivially parseable into fixed-length byte sequences. Just do that and use a search tree. Or, IDK; this is an extremely solved problem, there are probably even better solutions out there – but I promise you text regex is involved in none of the good ones.
Even for actual string matching, any decent regex engine will compile and optimise an alternation
a|b|c|...better than this text wrangling will. Unless you have actual benchmarks showing this gives you an advantage with the engine you’re using, you’re just introducing complexity for no gain.Also of note. Regexlicensing.org has issued no licences to date for use of regex in production environments
https://regexlicensing.org/license/
Not much substance to their argument, mostly just whining. Funny website, though.
It’s called “allowlist” and “denylist” nowadays as it’s easier to understand for non-native speakers and not racist.
I feel like there’s an easier and faster way to match IP addresses than regex, e.g. the search tree apparia suggested. At least use bytes to match 😄
https://en.wikipedia.org/wiki/Blacklist_(computing)#Controversy_over_terminology
(See the section that follows for more context.)
Yes, but does it really hurt you to make your software more accessible?
What good arguments do you have for the term blacklist?
“Denylist” is easier to understand and doesn’t spark discussions. Nobody will be offended, whether it’s technically correct to be offended or not.
I’m not a person of colour but your answer still insults me, because it’s so tone deaf.